search

ayushnix / tessen

an interactive menu to autotype and copy pass and gopass data
GNU General Public License v2.0
74 stars 12 forks source link

Implementation of #4 issue #9

Closed t0fik closed 2 years ago

t0fik commented 2 years ago

Allows user to configure any dmenu compatible backend using --backed option or TESSEN_BACKEND environment variable.

ayushnix commented 2 years ago

Looks good to me.

Thanks for contributing to tessen.

ayushnix commented 2 years ago

Looking back at this PR, I don't think it was a good idea to want #4 and merge this. I can't think of a method to parse arbitrary arguments such as 

tessen -b 'rofi -dmenu -font "Roboto Mono 12"'

without using xargs or eval, which I don't want to use in tessen. In addition, this introduces the possibility of executing arbitrary binaries that can interact with data from pass.

I'm thinking of removing this feature entirely and reverting to the whitelist method that tessen had before #9 was merged. What do you think?

t0fik commented 2 years ago

@ayushnix I'm working on the solution without xargs and eval. It should be ready today.

t0fik commented 2 years ago

Fix for issue #12 in PR #13