ayushsharma82 / ESP-DASH

Blazing fast library to create a functional, on-device dashboard for ESP8266 / ESP32 / RP2040
https://espdash.pro
GNU General Public License v3.0
977 stars 200 forks source link

Progress card should show the current value #220

Closed mathieucarbou closed 3 months ago

mathieucarbou commented 5 months ago

request to change from:

            <span>{ calculateProgress(currentValue, data.min, data.max).toFixed(0) }<span class="font-normal">{ data.symbol }</span></span>

to

            <span>{ currentValue }<span class="font-normal">{ data.symbol }</span></span>

The percentage 0-100 is only linked to the computation of the progress bar. But the value displayed should be in relation with the value sent from the ESP, and also in relation with the min and max set in the card definition.

mathieucarbou commented 5 months ago

I.e. i have a slider 0 - 10000 that I am swapping with a progress bar 0 - 10000:

image

image

The slider shows the correct value after the fix and the % for the progress bar correctly computed.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.