search

ayushsharma82 / EasyDDNS

Easy to Use ESP8266 & ESP32 DDNS Update Client Library.
MIT License
197 stars 59 forks source link

Fixed EasyDDNS.cpp #10

Closed comertial closed 5 years ago

comertial commented 5 years ago

the get public ip block should be before the generate update url block.. This way 1) new_ip gets the new ip next 2) update_url gets the link with the new ip 3) and then we check and update

the way it was before, was 1) update_url gets the link with the OLD new_ip value (so its the old ip) 2) new_ip gets updated (but update_url does not!!!) 3) we check and update (basicly with the old ip!!)

ayushsharma82 commented 5 years ago

My foolish mistakes lol.

Thanks for the PR. I will merge it.