ayushsharma82 / ElegantOTA

OTA updates made slick and simple for everyone!
https://elegantota.pro
GNU Affero General Public License v3.0
643 stars 119 forks source link

ElegantOTA.cpp:73:71: error: 'FS_end' was not declared in this scope; #129

Closed VaAndCob closed 1 year ago

VaAndCob commented 1 year ago

I installed the library both on PC (windows) and Apple Mac(intel5) both machines are Arduino 2.2.1

ayushsharma82 commented 1 year ago

Check if both PC and macbook have the same board version installed?

On Mon, 25 Sep 2023 at 6:35 PM, Va&Cob @.***> wrote:

I installed library both on PC (windows) and Apple Mac(intel5) both machine are Arduino 2.2.1

  • Arduino on PC (windows10) compiled and run fine.
  • Arduino on macbook throw error messages: /Volumes/sdcard64gb/Dropbox/Arduino/Sketch/libraries/ElegantOTA/src/ElegantOTA.cpp: In lambda function: /Volumes/sdcard64gb/Dropbox/Arduino/Sketch/libraries/ElegantOTA/src/ElegantOTA.cpp:73:71: error: 'FS_end' was not declared in this scope; did you mean 'va_end'? 73 | uint32_t update_size = mode == OTA_MODE_FILESYSTEM ? ((size_t)FS_end - (size_t)FS_start) : ((ESP.getFreeSketchSpace() - 0x1000) & 0xFFFFF000); | ^~ | va_end /Volumes/sdcard64gb/Dropbox/Arduino/Sketch/libraries/ElegantOTA/src/ElegantOTA.cpp:73:88: error: 'FS_start' was not declared in this scope; did you mean 'va_start'? 73 | uint32_t update_size = mode == OTA_MODE_FILESYSTEM ? ((size_t)FS_end - (size_t)FS_start) : ((ESP.getFreeSketchSpace() - 0x1000) & 0xFFFFF000); | ^~~~ | va_start

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK4NSE5TIEZBDNIVAZLEW3X4F6Q7ANCNFSM6AAAAAA5GCBRLI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

VaAndCob commented 1 year ago

it's exactly the same ESP8266 module, (Generic ESP8266) but Arduino IDE was unable to compile due to error messages above. (both PC and Macbook use library and sketch code from the same resource (dropbox) . I wonder why PC was successful compile but not macbook. Are "FS_end" and "FS_start" not declare error come from different "FS.h" ?

ayushsharma82 commented 1 year ago

FS_end and FS_start are defined in FS.h but my speculation is that platform/board version is different. Check it in Board Manager > ESP8266

On Mon, 25 Sep 2023 at 6:58 PM, Va&Cob @.***> wrote:

it's exactly the same ESP8266 module, (Generic ESP8266) but Arduino IDE was unable to compile due to error messages above. (both PC and Macbook use library and sketch code from the same resource (dropbox) . I wonder why PC was successful compile but not macbook. Are "FS_end" and "FS_start" not declare error come from different "FS.h" ?

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/129#issuecomment-1733713198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK4NSF7NWP7NGV6HDBWJVLX4GBGDANCNFSM6AAAAAA5GCBRLI . You are receiving this because you commented.Message ID: @.***>

VaAndCob commented 1 year ago

it's the latest version. ESP8266 Board(3.0.2). No update both machine lately.

ayushsharma82 commented 1 year ago

@VaAndCob It's an issue in ESP8266 Board 3.0.2 version. I compiled the example successfully with 3.1.2 (latest) on my MacBook (M1)

VaAndCob commented 1 year ago

I manually copied and replace arduino core library file FS.h and FS.cpp from github ESP8266 arduino core but it gave the same error messages.

ayushsharma82 commented 1 year ago

I manually copied and replace arduino core library file FS.h and FS.cpp from github ESP8266 arduino core but it gave the same error messages.

Consider updating to 3.1.2 release of ESP8266 board. It does not compile with 3.0.2

VaAndCob commented 1 year ago

I manually copied and replace arduino core library file FS.h and FS.cpp from github ESP8266 arduino core but it gave the same error messages.

Consider updating to 3.1.2 release of ESP8266 board. It does not compile with 3.0.2

oh ok, I must manually update to 3.1.2 Thank you a lot.

ayushsharma82 commented 1 year ago

@VaAndCob As this is a new release, I will need a small feedback. Once you have tried ElegantOTA, let me know if it updated your ESP8266 without any hiccups or not.

VaAndCob commented 1 year ago

20230925_210702.jpg

[ElegantOTA] OTA Mode: Firmware [ElegantOTA] MD5: 441018525208457705bf09a8ee3c1093 sleep disable [ElegantOTA] Rebooting... station: ee:b1:48:1f:20:b8 leave, AID = 1

I confirm it works like a charm.

ayushsharma82 commented 1 year ago

Awesome! Thanks for the feedback.