search

ayushsharma82 / ElegantOTA

OTA updates made slick and simple for everyone!
https://elegantota.pro
GNU Affero General Public License v3.0
643 stars 119 forks source link

Use of absolute paths causes failures with subpath-based reverse proxying #194

Closed gongloo closed 2 months ago

gongloo commented 5 months ago

It'd be great to see relative paths used throughout the JS code.

In use cases involving reverse proxies, it's common to host multiple devices behind a single HTTP proxy using subpath-based routing of requests. In my case, I've got a thermostat device accessible at http://hostname/thermostat. I can of course hit http://hostname/thermostat/update, but the OTA start requests fail right off the bat because they use absolute /ota paths.

Should be a relatively straightforward fix in the JS. Happy to submit a PR given the JS source you'd like to see modified.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gongloo commented 4 months ago

Would still love to see this land. Happy to help modify the code!

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 5 days with no activity.