ayushsharma82 / ElegantOTA

OTA updates made slick and simple for everyone!
https://elegantota.pro
GNU Affero General Public License v3.0
643 stars 119 forks source link

beginResponse_P - Braking Change in mathieucarbou / ESPAsyncWebServer for ESP32 in release 3.0.2 #201

Closed hagre closed 3 months ago

hagre commented 4 months ago

see: https://github.com/mathieucarbou/ESPAsyncWebServer/pull/39

The beginResponse_P is only avaliable for ESP8266 at release 3.0.2

mathieucarbou commented 4 months ago

FYI, I've opened a PR to add back these methods as deprecated: https://github.com/mathieucarbou/ESPAsyncWebServer/pull/46 I hope to be able to merge it soon and release a new version of ESPAsyncWebServer.

ayushsharma82 commented 4 months ago

@mathieucarbou Always keep backwards compatibility. :) Too many little microcontrollers rest on your shoulders now.

sachiger commented 4 months ago

on ElegantOTA release 3.1.2 (ESP8266 async mode) no matching function for call to 'AsyncWebServerRequest::beginResponse folding back to 3.1.1 works fine

ayushsharma82 commented 4 months ago

@sachiger as mathieu mentioned, have you updated your AsyncWebServer dependency to version >= 3.0.6?

sachiger commented 4 months ago

I have ESPAsyncWebServer by Iacamera 3.1.0 installed. I am not sure if I need to do anything else Thanks

On Sat, Jul 6, 2024 at 4:07 PM Ayush Sharma @.***> wrote:

@sachiger https://github.com/sachiger as mathieu mentioned, have you updated your AsyncWebServer dependency to version >= 3.0.6?

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/201#issuecomment-2211764645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWZDU3IC4KURR6X3JFQHR3ZK7TXRAVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG43DINRUGU . You are receiving this because you were mentioned.Message ID: @.***>

ayushsharma82 commented 4 months ago

@sachiger That’s not our recommended dependency: https://docs.elegantota.pro/async-mode/#dependencies

sachiger commented 4 months ago

Hi, I replaced ESPAsyncWebServer to 3.0.6 The web server (application) stopped responding, unless the HTML page is very simple with ESPAsyncWebServer 3.1.0 and ElegantOTA 3.1.1 all works fine. Any ideas? Thanks

On Sat, Jul 6, 2024 at 4:16 PM Ayush Sharma @.***> wrote:

@sachiger https://github.com/sachiger That’s not our recommended dependency: https://docs.elegantota.pro/async-mode/#dependencies

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/201#issuecomment-2211766825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWZDUZ4CAJ3AR2SJYNKP6TZK7U25AVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG43DMOBSGU . You are receiving this because you were mentioned.Message ID: @.***>

mathieucarbou commented 4 months ago

Hi, I replaced ESPAsyncWebServer to 3.0.6 The web server (application) stopped responding, unless the HTML page is very simple with ESPAsyncWebServer 3.1.0 and ElegantOTA 3.1.1 all works fine. Any ideas? Thanks

Maybe clan all your libraries. You must have conflicts. I guess you are using Arduino IDE... FYI ESPAsyncWebServer 3.1.0 does not exist: this is a guy who released original repo under a new version, which under some case might cause a mess.

https://github.com/arduino/library-registry/pull/4585#

I suggest you cleanup the dependencies, or use a real dev environment like Vscode with PlatformIO who are able to correctly deal with dependencies and versions.

sachiger commented 4 months ago

I tried to work with VScode/PlatformIO but failed to configure it right. Working on Arduino IDE esphome-ESPAsyncTCP 2.0.0 failed to install, collapsing all dependencies. Any solution/reason why it wouldn't install? Many thanks Sachi

On Sun, Jul 7, 2024 at 6:01 PM Mathieu Carbou @.***> wrote:

Hi, I replaced ESPAsyncWebServer to 3.0.6 The web server (application) stopped responding, unless the HTML page is very simple with ESPAsyncWebServer 3.1.0 and ElegantOTA 3.1.1 all works fine. Any ideas? Thanks … <#m7216425539842636176> On Sat, Jul 6, 2024 at 4:16 PM Ayush Sharma @.> wrote: @sachiger https://github.com/sachiger https://github.com/sachiger https://github.com/sachiger That’s not our recommended dependency: https://docs.elegantota.pro/async-mode/#dependencies https://docs.elegantota.pro/async-mode/#dependencies — Reply to this email directly, view it on GitHub <#201 (comment) https://github.com/ayushsharma82/ElegantOTA/issues/201#issuecomment-2211766825>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWZDUZ4CAJ3AR2SJYNKP6TZK7U25AVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG43DMOBSGU https://github.com/notifications/unsubscribe-auth/AIWZDUZ4CAJ3AR2SJYNKP6TZK7U25AVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRG43DMOBSGU . You are receiving this because you were mentioned.Message ID: @.>

Maybe clan all your libraries. You must have conflicts. I guess you are using Arduino IDE... FYI ESPAsyncWebServer 3.1.0 does not exist: this is a guy who released original repo under a new version, which under some case might cause a mess.

arduino/library-registry#4585 https://github.com/arduino/library-registry/pull/4585

I suggest you cleanup the dependencies, or use a real dev environment like Vscode with PlatformIO who are able to correctly deal with dependencies and versions.

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/201#issuecomment-2212478186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWZDU4TYLY5RTC4R75RAOLZLFJ37AVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGQ3TQMJYGY . You are receiving this because you were mentioned.Message ID: @.***>

mathieucarbou commented 4 months ago

@sachiger : you can take a look at the pio file in this project as a start exemple. You can have pio compile your ino file. This is how this project examples can be locally built.

sachiger commented 4 months ago

Thank you for your prompt response. Where Can I find this PIO file?

On Fri, Jul 19, 2024 at 8:18 PM Mathieu Carbou @.***> wrote:

@sachiger https://github.com/sachiger : you can take a look at the pio file in this project as a start exemple. You can have pio compile your ino file. This is how this project examples can be locally built.

— Reply to this email directly, view it on GitHub https://github.com/ayushsharma82/ElegantOTA/issues/201#issuecomment-2239711791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWZDU77VQDTGR6OB54XTTTZNFC5FAVCNFSM6AAAAABKBSZTYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZG4YTCNZZGE . You are receiving this because you were mentioned.Message ID: @.***>

mathieucarbou commented 4 months ago

Thank you for your prompt response. Where Can I find this PIO file?

In this project: platformio.ini

ayushsharma82 commented 3 months ago

Incase someone wants to use some other fork of ESPAsyncWebServer: https://docs.elegantota.pro/async-mode/#use-of-unrecommended-dependencies-experimental