search

ayushsharma82 / ElegantOTA

OTA updates made slick and simple for everyone!
https://elegantota.pro
GNU Affero General Public License v3.0
643 stars 119 forks source link

Read params from src/config.h. Precedence given to platformio config. #204

Open gongloo opened 4 months ago

gongloo commented 4 months ago

Many projects use src/config.h to define hostname, username, and password constants in C++ outside of version control using .gitignore. Not sure if it's in fitting with this project's aesthetic to be (admittedly) hackishly pulling from src/config.h if it exists, but this is a huge convenience and makes it easier to keep credentials in a single, secure place. Happy to take suggestions on improvements.

github-actions[bot] commented 3 months ago

This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid.

gongloo commented 3 months ago

Happy to take suggestions on how to improve this PR. Please advise!

github-actions[bot] commented 2 months ago

This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid.