search

ayushsharma82 / WebSerial

A remote terminal library for wireless microcontrollers to log, monitor or debug your firmware/product
https://webserial.pro
GNU Affero General Public License v3.0
461 stars 108 forks source link

Making WebSerial external for propper includes #4

Closed jvoj closed 2 years ago

jvoj commented 4 years ago

Had a few problems when icluding your library because it did not called external variable but just created variable in headerfile (WebSerialClass WebSerial;). So I splitted header and implementation which should help.

ayushsharma82 commented 4 years ago

Thanks for the effort in making WebSerial better!

I'll merge it in couple of days after a basic test.

rprediger commented 2 years ago

I had the same problem and the solution is exactly that. Here is my support for the solution to be approved as soon as possible.

ayushsharma82 commented 2 years ago

Superseded by v1.2.0 @ f53b7a4 to maintain the latest additions to the repository. Thanks for reporting the issue.