search

ayushsharma82 / WebSerial

A remote terminal library for wireless microcontrollers to log, monitor or debug your firmware/product
https://webserial.pro
GNU Affero General Public License v3.0
461 stars 107 forks source link

Fix warnings and other little things #81

Closed mathieucarbou closed 1 week ago

mathieucarbou commented 3 weeks ago

On Arduino 3, type definition has changed. It is recommended to use PRIu32 / PRId32 / PRIu16 / PRId16 / etc for printf formats

mathieucarbou commented 3 weeks ago

@ayushsharma82 : this PR is ready

ayushsharma82 commented 1 week ago

Needs conflicts to be resolved.

mathieucarbou commented 1 week ago

Needs conflicts to be resolved.

This PR was containing all the improvement to the existing code, without the WSL_HIGH_PERF version.

Since you've merged the WSL_HIGH_PERF version into dev, this PR is not needed for dev since the WSL_HIGH_PERF version also included all the little improvements to the existing code.

I've changed the base to master: depending on your release plan and process, it can either be merged to master or be closed if dev will be merged to master ;-)