search

ayyaruq / zanarkand

Network capture library for realtime FFXIV Frame and FFXIV Message reading from a TCP/IP stream
MIT License
20 stars 8 forks source link

Subscriber sync pools for readers #10

Closed ayyaruq closed 3 years ago

ayyaruq commented 3 years ago

Readers should use a pool to reduce allocation overhead. Some large packet bursts can cause problems with the zlib decoder blocking the frame buffer. Pooled readers should be properly closed when the subscriber is shutdown.

ayyaruq commented 3 years ago

Implemented, but doesn't actually help. Issue is due to the channel blocking and the reassembler dumping packets. I don't think we can fix this by making the channel bigger, so instead going to relocate the frame assembly outside of the packet reassembler.