search

az-digital / arizona-bootstrap

UArizona's front-end toolkit based on Bootstrap 4 and 5.
https://digital.arizona.edu/arizona-bootstrap
MIT License
5 stars 8 forks source link

Checks on pull requests should include visual regression tests. #523

Open mmunro-ltrr opened 2 years ago

mmunro-ltrr commented 2 years ago

Motivation

Arizona Bootstrap has no visual regression testing of proposed changes, although UA Bootstrap used to offer some.

Is your feature request related to a problem? Please describe.

A pull request can generate a completely broken review site, but not warn of this in any way.

Proposed Resolution

Describe the solution you'd like

Automated visual comparisons of the documentation site (internally built, not deployed) before and after a proposed change, with differences flagged as warnings (not blocking pull requests that add new features).

trackleft commented 2 years ago

@mmunro-ltrr I made a working version of this for https://github.com/az-digital/arizona-gatsby/pull/423/files I wonder if that would be useful

mmunro-ltrr commented 2 years ago

@trackleft: interesting! I'd also been looking at what twbs has been doing (they're getting free support from BrowserStack). But this is a great ready-to-reuse option.