search

az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.
https://quickstart.arizona.edu
GNU General Public License v2.0
30 stars 20 forks source link

Update drupal/environment_indicator requirement from 4.0.10 to 4.0.18 #3457

Open dependabot[bot] opened 1 month ago

dependabot[bot] commented 1 month ago

Updates the requirements on drupal/environment_indicator to permit the latest version.

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

joeparsons commented 1 month ago

Looks like the issue introduced in 4.0.11 that has prevented us from upgrading this module is still not fixed as of this new release (😞) but we're falling pretty far behind now so we may want to look into patches or other workarounds for that problem.

joeparsons commented 4 weeks ago

I added a config file to this PR branch that should effectively disable the deployment indicator/version from being displayed which would maintain our current environment indicator behavior (at least on Pantheon).

The more I think about this, though, I think I've realized that my biggest gripe with the module changes is that it prepends the deployment identifier or version number (in parentheses) to the environment name that we configure per-environment on Pantheon that also includes parentheses.

So our existing Dev (Pantheon) becomes (xxxxxx) Dev (Pantheon) and our existing LIVE (Pantheon) beceomes (live_xxx) LIVE (Pantheon).

I've created a PR for the Pantheon upstream that removes the (Pantheon) suffix from our environment names which I think would solve most of my concern with the changes introduced in the module without needing to configure any module settings a certain way: https://github.com/az-digital/az-quickstart-pantheon/pull/251

joeparsons commented 4 weeks ago

@trackleft please feel free to revert/remove the config file I added to this PR.