az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.
https://quickstart.arizona.edu
GNU General Public License v2.0
30 stars 20 forks source link

Fixes #3305 Provide Attribute Filtering for News Export #3468

Closed tadean closed 4 days ago

tadean commented 4 weeks ago

This PR adds a views filter to the News Export API that understands how to translate Enterprise-wide attribute keys to local taxonomy terms.

Related issues

3305

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

Drupal core

Drupal contrib projects

Checklist

tadean commented 4 weeks ago

Topics for discussion/testing:

The impact of the above may be affected by the fact that this API is relatively new and it is likely that CatCloud is likely the primary or only stakeholder at this time.

trackleft commented 3 weeks ago

Should we add a dependency here on az_enterprise_attributes_import? https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_news/az_news_export/az_news_export.info.yml

tadean commented 3 weeks ago

Should we add a dependency here on az_enterprise_attributes_import? https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_news/az_news_export/az_news_export.info.yml

Attributes are provided by az_core - only the bulk creation of the individual terms comes from az_enterprise_attributes_import

tadean commented 5 days ago

Refactored to avoid usage of hook_field_views_data_alter() as this being a term reference field in conjunction with that hook invites the taxonomy module to replace our plugin.

This avoids needing to alter module weight.

joeparsons commented 4 days ago

We should update the documentation here: https://quickstart.arizona.edu/site-admin/integrations/catcloud-news-export