az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.
https://quickstart.arizona.edu
GNU General Public License v2.0
30 stars 20 forks source link

Remove `az_google_tag`'s dependency on `ctools` and remove `ctools` from `az_quickstart`. #3481

Closed trackleft closed 1 week ago

trackleft commented 2 weeks ago

Description

Release notes:

Remove dependency on ctools, Removing Chaos Tools

~~**IMPORTANT**: Chaos Tools (`ctools`) dependency  removed from Quickstart 2.~~

Quickstart no longer has a runtime dependency on the ctools module, and the module has been slated for removal. This might cause problems if other modules implicitly use ctools functionality without depending on it.

Note that for backwards compatibility, the composer definition still depends on the ctools project, but it's no longer installed on new projects and existing projects may uninstall it if they are not using it.

The composer definition is there so that existing sites do not automatically have the code removed underneath them and continue to work. This will be removed in the future in a new major version. It is recommended to either add an explicit dependency on ctools if you plan to keep using it or uninstall it.

To fully remove ctools from the project, add a replace section to the root composer.json:

 "replace": {
        "drupal/ctools": "*"
    },
Note that this will also skip it in case another module depends on it and the definition will need to be removed then.

Before uninstalling ctools, verify that no configuration dependencies remain on views or other config entities. Views should have that dependency removed automatically when resaving them.

Related issues

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

Drupal core

Drupal contrib projects

Checklist

joeparsons commented 2 weeks ago
# composer why drupal/ctools
az-digital/az_quickstart dev-dependabot/composer/drupal/ctools-4.1.0-remove-ctools requires drupal/ctools (*) 
drupal/pathauto          1.12.0                                                    requires drupal/ctools (*) 
joeparsons commented 2 weeks ago

FWIW, I think we could just make this change directly to the mian branch (change the target branch for this PR) as an alternative to the dependabot PR instead of targeting the dependabot PR branch.

trackleft commented 2 weeks ago
www-data@8ded398cc170:/app$ composer why drupal/ctools
az-digital/az_quickstart  2.10.4  requires  drupal/ctools (3.14.0)  
drupal/pathauto           1.12.0  requires  drupal/ctools (*)       
trackleft commented 2 weeks ago

Add to https://github.com/az-digital/az_quickstart/blob/main/az_quickstart.install#L80-L83