search

az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.
https://quickstart.arizona.edu
GNU General Public License v2.0
30 stars 20 forks source link

Enhance accessibility on card headers #3504

Open danahertzberg opened 6 days ago

danahertzberg commented 6 days ago

Motivation

I want to ensure card headers are accessible if they are linked.

Is your feature request related to a problem? Please describe.

Linked headings were identified as not visually different in this PR: https://github.com/az-digital/az_quickstart/pull/3463#pullrequestreview-2133571746

Proposed Resolution

Look into changing card headings (or all headings?) if they are links. Challenges include the link being in a card on a colored background or not.

Additional context

Email thread between Dana and Jeff

From: Bishop, Jeff - (jeffbis) jeffbis@arizona.edu Date: Wednesday, June 26, 2024 at 2:55 PM To: Hertzberg, Dana L - (danahertzberg) danahertzberg@arizona.edu Subject: RE: Card accessibility PR

Frankly, the color scheme should be the same that you would put on any other linked item honestly. Now, how you make that look with a heading is a bit tricky but perhaps that is where we need to do a bit of research …

From: Hertzberg, Dana L - (danahertzberg) danahertzberg@arizona.edu Sent: Wednesday, June 26, 2024 11:53 AM To: Bishop, Jeff - (jeffbis) jeffbis@arizona.edu Subject: Re: Card accessibility PR

Wonderful. Thank you for the clarification!

From: Bishop, Jeff - (jeffbis) [jeffbis@arizona.edu](mailto:jeffbis@arizona.edu) Date: Wednesday, June 26, 2024 at 2:27 PM To: Hertzberg, Dana L - (danahertzberg) [danahertzberg@arizona.edu](mailto:danahertzberg@arizona.edu) Subject: RE: Card accessibility PR

I am ok with the initial merge and we can discuss the visuals next …

From: Hertzberg, Dana L - (danahertzberg) [danahertzberg@arizona.edu](mailto:danahertzberg@arizona.edu) Sent: Wednesday, June 26, 2024 11:09 AM To: Bishop, Jeff - (jeffbis) [jeffbis@arizona.edu](mailto:jeffbis@arizona.edu) Subject: Card accessibility PR

Hey Jeff,

On this PR for updating card links, do you see the need to make clickable headings visually different as a blocker for this PR?

https://github.com/az-digital/az_quickstart/pull/3463#issuecomment-2187360456

Or would it be okay to start a separate issue for the work to make linked headings visually different from non-linked headings? And we can merge this initial PR now.

Thanks! Dana