search

az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.
https://quickstart.arizona.edu
GNU General Public License v2.0
30 stars 20 forks source link

lando build with default config creates bad URL, inaccessible site #417

Open jcheek opened 3 years ago

jcheek commented 3 years ago

Standing up QS2 with no changes creates the site at an invalid URL (http://az_quickstart.lndo.site/) which cannot be accessed. An underscore is invalid as part of a host name, so az_quickstart/.lndo.site is invalid and will not load the site.

Repro steps

  1. $ git clone https://github.com/az-digital/az_quickstart.git
  2. $ cd az_quickstart
  3. $ lando rebuild -y
  4. Verify incorrect http://az_quickstart.lndo.site/ site
  5. Surf to http://az_quickstart.lndo.site/
  6. Verify 400 error
  7. Edit .lando.yml and replace az_quickstart with az-quickstart
  8. $ lando destroy -y && lando rebuild -y
  9. Verify correct http://az-quickstart.lndo.site/ site
  10. Surf to http://az-quickstart.lndo.site/
  11. Verify correct site installation screen

Expected behavior

The default .lando.yml will not stand up a site with an invalid URL.

Proposed resolution

Alter the .lando.yml to use a different name without an underscore, such as az-quickstart.

Notes

After building, lando shows this message:

 NAME            az_quickstart
 LOCATION        /Users/joseph/Documents/Source/managed/az_quickstart
 SERVICES        appserver, database, node
 APPSERVER URLS  https://localhost:32787
                 http://localhost:32788
                 http://az_quickstart.lndo.site/
                 https://az_quickstart.lndo.site/

Using the localhost URLs work correctly, as they have no underscores in them.

Screenshots

Side-by-side browser windows showing bad and good URLs and their respective responses. Screen Shot 2020-12-10 at 3.49.51 PM.png

trackleft commented 2 years ago

Does anyone remember if there was a reason that we didn't do this?