Open jcheek opened 3 years ago
Standing up QS2 with no changes creates the site at an invalid URL (http://az_quickstart.lndo.site/) which cannot be accessed. An underscore is invalid as part of a host name, so az_quickstart/.lndo.site is invalid and will not load the site.
$ git clone https://github.com/az-digital/az_quickstart.git
$ cd az_quickstart
$ lando rebuild -y
.lando.yml
$ lando destroy -y && lando rebuild -y
The default .lando.yml will not stand up a site with an invalid URL.
Alter the .lando.yml to use a different name without an underscore, such as az-quickstart.
az-quickstart
After building, lando shows this message:
NAME az_quickstart LOCATION /Users/joseph/Documents/Source/managed/az_quickstart SERVICES appserver, database, node APPSERVER URLS https://localhost:32787 http://localhost:32788 http://az_quickstart.lndo.site/ https://az_quickstart.lndo.site/
Using the localhost URLs work correctly, as they have no underscores in them.
Side-by-side browser windows showing bad and good URLs and their respective responses.
Does anyone remember if there was a reason that we didn't do this?
Standing up QS2 with no changes creates the site at an invalid URL (http://az_quickstart.lndo.site/) which cannot be accessed. An underscore is invalid as part of a host name, so az_quickstart/.lndo.site is invalid and will not load the site.
Repro steps
$ git clone https://github.com/az-digital/az_quickstart.git
$ cd az_quickstart
$ lando rebuild -y
.lando.yml
and replace az_quickstart with az-quickstart$ lando destroy -y && lando rebuild -y
Expected behavior
The default .lando.yml will not stand up a site with an invalid URL.
Proposed resolution
Alter the .lando.yml to use a different name without an underscore, such as
az-quickstart
.Notes
After building, lando shows this message:
Using the localhost URLs work correctly, as they have no underscores in them.
Screenshots
Side-by-side browser windows showing bad and good URLs and their respective responses.![Screen Shot 2020-12-10 at 3.49.51 PM.png](https://images.zenhubusercontent.com/5fce57d921c89264b6c133bf/f34e16d5-a41e-4113-804c-43af98d11732)