PHP 8.0 compatibility needed for Quickstart

az-digital / az_quickstart

UArizona's web content management system built with Drupal 10.

https://quickstart.arizona.edu

GNU General Public License v2.0

30 stars 20 forks source link

PHP 8.0 compatibility needed for Quickstart #983

Closed mmunro-ltrr closed 2 years ago

mmunro-ltrr commented 3 years ago

Motivation

Drupal 9 recommends PHP v8.0 (as well as v7.4), but Quickstart's dependencies are not compatible with v8.

Is your feature request related to a problem? Please describe.

A Quickstart installation fails almost immediately on a LAMP stack using PHP v8.0.8.

Proposed Resolution

Investigate workarounds and version bumps for Quickstart in PHP 8 test environments.

mmunro-ltrr commented 3 years ago

Looks like it might just need a version bump of liuggio/fastest to v1.8.0. That would be a PR on the az-quickstart-dev repository, and should follow PR 20 there (@joeparsons replacing raveren/kint with kint-php/kint). A local Lando build worked.

quickstart_with_php_8

michaelhagedon commented 2 years ago

Looks like liuggio-fastest is updated in -dev, so now with lando updated to PHP 8, the site installs and tests pass via lando phpunit-fastest.

joeparsons commented 2 years ago

I think the immediate issue(s) that were causing these failures have been resolved.