search

aza547 / wow-recorder

A desktop screen recorder application that records and saves videos of in-game World of Warcraft encounters, and provides a graphical user interface to view the replays. It is free, open source and contains no adverts.
http://www.warcraftrecorder.com
Other
151 stars 31 forks source link

Classic raid encounter release spirit zone out problem #201

Open aza547 opened 2 years ago

aza547 commented 2 years ago

Pre-empting a problem on classic. It's possible to zone out of an encounter in progress. I did this today on a Malygos wipe.

The combatlog didn't have an ENCOUNTER_END event for the wipe as a result.

This can't happen on retail so we probably don't handle it robustly. We should give it some thought.

aza547 commented 2 years ago

WoWCombatLog-101122_180649.txt WarcraftRecorder-2022-10-11.log

Surprisingly WR seemed to handle this OK. I got a recording of the kill but not the wipe.

tdaugaard commented 2 years ago

I guess this is what happened - what would the ideal outcome be?

Zone changing out/in and no ENCOUNTER_END is basically how abandoned Mythic+ runs are recorded.

Combatlog:

10/11 21:49:59.524  SPELL_AURA_APPLIED,Player-4811-036B0F06,"Alexpals-Giantstalker",0x511,0x0,Player-4811-036B0F06,"Alexpals-Giantstalker",0x511,0x0,53755,"Flask of the Frost Wyrm",0x1,BUFF
10/11 21:49:59.746  ZONE_CHANGE,571,"Borean Tundra",0
10/11 21:49:59.746  COMBAT_LOG_VERSION,9,ADVANCED_LOG_ENABLED,1,BUILD_VERSION,3.4.0,PROJECT_ID,11
10/11 21:49:59.746  ZONE_CHANGE,571,"Borean Tundra",0
10/11 21:49:59.746  MAP_CHANGE,114,"Borean Tundra",4897.919922,1054.170044,8570.830078,2806.250000
10/11 21:50:53.338  COMBAT_LOG_VERSION,9,ADVANCED_LOG_ENABLED,1,BUILD_VERSION,3.4.0,PROJECT_ID,11
10/11 21:50:53.338  ZONE_CHANGE,616,"The Eye of Eternity",3
10/11 21:50:53.338  MAP_CHANGE,141,"The Eye of Eternity",897.841003,611.127991,1466.780029,1036.709961
10/11 21:50:53.338  MAP_CHANGE,141,"The Eye of Eternity",897.841003,611.127991,1466.780029,1036.709961
10/11 21:50:54.298  SPELL_AURA_APPLIED,Player-4811-038F79C9,"Flakestronk-Giantstalker",0x40512,0x0,Player-4811-038F79C9,"Flakestronk-Giantstalker",0x40512,0x0,71,"Defensive Stance",0x1,BUFF
(...)
10/11 21:52:28.723  ENCOUNTER_START,734,"Malygos",3,10,616,11

WR log:

[2022-10-11 21:52:28.732] [error] [LogUtils] Avoiding error by not attempting to start recording true false

According to the logs, you didn't get a recording of Malygos only Giantstalker.

I guess one way could be to simply end an encounter if a new one is seen, rather than aborting it as seen above.

I can't think of a valid situation where we're recording and the app wants to start a new recording where that isn't the correct thing to do; end the current recording and start a new one.

That could bring with it some issues about timing, though.

aza547 commented 4 months ago

Was thinking a WA to just block the release button in classic raid encounters might do here.