azaghal / pydenticon

Pydenticon is a small utility library that can be used for deterministically generating identicons based on the hash of provided data.
BSD 3-Clause "New" or "Revised" License
66 stars 10 forks source link

Fixed python3 related lack of encoding in the digest test #3

Closed bjura closed 9 years ago

azaghal commented 9 years ago

Could you let me know if there was any fix needed for this in the end or...? I was able to test my patch with at least Python 3.2.3 and 2.7.3 on my Debian Wheezy machine.

Otherwise, are you using Pydenticon yourself with Python 3? I was planning on making a release with support for Python 3, but got a bit busy in the meantime :)

If you're using Pydenticon with Python 3, I'll squeeze out 5 minutes ti make an updated package.

bjura commented 9 years ago

No, the version on your git is alright with both python 2 and 3 even on Jessy, I just took it from the pip where it's out of date and than looked at the code on github and than got mixed up and that's why this PR :-) We'd like to use it in our project (pisak, you can check on my account) with python3 so it would be great if you could put it in pip

On 03.12.2014 15:10, Branko Majic wrote:

Could you let me know if there was any fix needed for this in the end or...? I was able to test my patch with at least Python 3.2.3 and 2.7.3 on my Debian Wheezy machine.

Otherwise, are you using Pydenticon yourself with Python 3? I was planning on making a release with support for Python 3, but got a bit busy in the meantime :)

If you're using Pydenticon with Python 3, I'll squeeze out 5 minutes ti make an updated package.

— Reply to this email directly or view it on GitHub https://github.com/azaghal/pydenticon/pull/3#issuecomment-65411874.

azaghal commented 9 years ago

Ok, I was one lazy arse, but I finally release 0.2. It's a small library, but do let me know if you think something could be improved ;)