azai91 / foursquared

Automatically exported from code.google.com/p/foursquared
Apache License 2.0
0 stars 0 forks source link

Capitalize TextEdit when adding venue #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Add a Venue when you type in the TextEdit fields the first letters are
not auto capitalized
2.
3.

What is the expected output? What do you see instead?

Autocapitalize.

What version of the product are you using? On what operating system?

hg

Please provide any additional information below.

Patch included below:

diff -r 7013edc60662 main/res/layout/add_venue_activity.xml
--- a/main/res/layout/add_venue_activity.xml    Tue Aug 11 13:50:27 2009 -0700
+++ b/main/res/layout/add_venue_activity.xml    Wed Aug 19 11:03:28 2009 -0400
@@ -14,7 +14,8 @@
         android:id="@+id/nameEditText"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
-        android:hint="Venue Name" />
+        android:hint="Venue Name" 
+       android:capitalize="words" />

       <TextView
         android:id="@+id/addressLabel"
@@ -27,7 +28,8 @@
         android:id="@+id/addressEditText"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
-        android:hint="Address" />
+        android:hint="Address"          
+       android:capitalize="words" />

       <EditText
         android:id="@+id/crossstreetEditText"
@@ -40,7 +42,8 @@
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:editable="false"
-        android:hint="City" />
+        android:hint="City" 
+        android:capitalize="words" />

       <TableLayout
@@ -53,14 +56,16 @@
             android:layout_width="0px"
             android:layout_weight="1"
             android:layout_height="wrap_content"
-            android:hint="State" />
+            android:hint="State"
+           android:capitalize="words" />
           <EditText
             android:id="@+id/zipEditText"
             android:layout_width="0px"
             android:layout_weight="1"
             android:layout_height="wrap_content"
             android:numeric="integer"
-            android:hint="Zip Code" />
+            android:hint="Zip Code"
+           android:capitalize="words"/>
         </TableRow>
       </TableLayout>

@@ -80,4 +85,4 @@
         android:hint="555-2368" />
     </LinearLayout>
   </ScrollView>
-</merge>
\ No newline at end of file
+</merge>

Original issue reported on code.google.com by dherbst on 19 Aug 2009 at 3:44

GoogleCodeExporter commented 8 years ago
the "capitalize" attribute is deprecated in favor of inputType="textCapWords" 
which I 
believe most layouts now have. Take a lok at those to see how its done.

You have commit access so feel free to write up a fix and submit. If you want 
and have 
experience using it, try out codereview.appspot.com and we can do a code review 
before 
you submit!

Original comment by jlapenna on 19 Aug 2009 at 4:44

GoogleCodeExporter commented 8 years ago
The latest build I'm using seems to do this already. I noticed it last night 
when
adding a venue?

Original comment by amiantos@gmail.com on 19 Aug 2009 at 6:07

GoogleCodeExporter commented 8 years ago
My mistake, I didn't pull changes for the past two days.  this can be closed.

Original comment by dherbst on 19 Aug 2009 at 6:13