Closed AS1100K closed 2 weeks ago
This is great, but you are missing two important options:
If you are using your own ClientID, these changes are also mandatory. Otherwise this option is useless. I saw that you added a custom scope, but then removed it as it was apparently not needed? What is the reason for this? - https://github.com/azalea-rs/azalea/pull/159/commits/d2bb6f4b6d1350b5973cde7c0eeed2570c0dfe7f
I saw that you added a custom scope, but then removed it as it was apparently not needed? What is the reason for this? - d2bb6f4
I removed the custom scope because that time i thought, that modifying permissions might not be required but rethinking it now, i realize that how can this be useful. Like you liquidboune client_id
only works with other scope i.e. not the default one. Also, may be you can take extra permissions and integrate your bot with that.
I will add custom scope and RpsTicket format and commit the changes
I just looked trough it an saw a lot of parameters with &'static str, and to my knowledge getting somethink as an &'static is not really possible (unless with a hardcoded str in this case) without leaking memory. Maybe using a non 'static str here is better?
Meant fields in the AuthOps struct mb
What this PR adds?
This PR addresses and closes the issue #130. It introduces two new functions in
azalea_client::Account
:microsoft_with_custom_client_id_and_scope
with_microsoft_access_token_and_custom_client_id_and_scope
.This PR will allow the developer, to customize the
client_id
andscope
, or use the nintendo switch one. Also, some other functions inauth.rs
likerefresh_ms_auth_token
,get_ms_link_code
,interactive_get_ms_auth_token
, etc. are modified and takes some extra parameters now. See the changes inauth.rs
for more information.Backwards Compatibility?
The existing functions
microsoft
andwith_microsoft_access_token
will maintain their current functionality. However, their implementations have been refactored to depend on the new functionsmicrosoft_with_custom_client_id_and_scope
andwith_microsoft_access_token_and_custom_client_id_and_scope
to avoid code duplication and facilitate easier maintenance.