search

azalea-rs / azalea

A collection of Rust crates for making Minecraft bots, clients, and tools.
https://azalea.matdoes.dev
MIT License
370 stars 47 forks source link

ClientboundSoundPacket deserialization failure when sent by playsound #89

Closed ghost closed 1 year ago

ghost commented 1 year ago

Executing commands like execute as <azalea bot> at @s run playsound minecraft:ambient.cave master @s ~ ~ ~ will cause a deserialization error in ClientboundSoundPacket.

Error: Error reading packet from Client: LeftoverData { data: [0, 0, 2, 48, 255, 255, 255, 244, 63, 128, 0, 0, 63, 128, 0, 0, 63, 103, 41, 228, 92, 95, 200, 35], packet_name: "ClientboundSoundPacket" }

mat-1 commented 1 year ago

Thanks for reporting, fixed :)

The issue came from Mojang changing ClientboundSoundPacket to be able to fall back to a ResourceLocation in 1.19.3-rc1 and me not noticing that change.

ghost commented 1 year ago

Thanks for the fast response & fix!