azat-co / expressworks

Learn Express.js from the author of one of the best books on Express.js—Pro Express.js— with this workshop that will teach you basics of Express.js.
MIT License
715 stars 220 forks source link

solution verification for 3 problems are broken #19

Closed nomind closed 10 years ago

nomind commented 10 years ago

In the expressworks@0.0.13, the solution verification for the last 3 problems

» PARAM PAM PAM                                                    
» WHAT'S IN QUERY                                                  
» JSON ME 

are broken and needs to be fixed. I am using node v0.10.26.

azat-co commented 10 years ago

what is broken? what are error messages?

nomind commented 10 years ago

As far I remember now, just try the provided solution for the last 3 problems in the set and even they were failing with error. You can just try them with the model solution and verify if there is an error.

azat-co commented 10 years ago

sometime node process hangs when after crashes, try killall, there was a thread here about it (it could be something else of course)

intrueder commented 10 years ago

they fail because verification code expects pretty printed JSON object. So, we can't just write

res.send(books)

we need to write instead something like

res.send(JSON.stringify(books, null, 2))

but it differs from official solution

nomind commented 10 years ago

Thanks for the update.

On Thu, Jun 5, 2014 at 1:05 PM, intrueder notifications@github.com wrote:

they fail because verification code expects pretty printed JSON object. So, we can't just write

res.send(books)

we need to write instead something like

res.send(JSON.stringify(books, null, 2))

but it differs from official solution

Reply to this email directly or view it on GitHub https://github.com/azat-co/expressworks/issues/19#issuecomment-45267404.

Cheers Anirban Mitra