search

azat-co / expressworks

Learn Express.js from the author of one of the best books on Express.js—Pro Express.js— with this workshop that will teach you basics of Express.js.
MIT License
715 stars 220 forks source link

Incompatible with Express 4 #21

Closed tburette closed 10 years ago

tburette commented 10 years ago

The workshop is incompatible with the version 4 of Express.

The main problem is with the changes in middleware whose names have changed and are now unbundled from Express, this needing to be npm installed. This affects primarily good_old_form.

I've also add some errors during verify but couldn't attribute it with certainty to Express v4.

azat-co commented 10 years ago

i think the process hands when there are crashes, killall usually helps

re: v4, i bet ;-)

johnbrett commented 10 years ago

@azat-co The issue is with express 4 not being bundled with urlencoded. User has to use the connect urlencded or will get the following error:

image

and this means the solution won't be read correctly either, so the following error occurs checking the solution:

image

How is the result found? If you point it out I can try put a PR together?

tburette commented 10 years ago

I confirm the problem on Good Old Form. Tested with expressworks 0.0.16

azat-co commented 10 years ago

this is fixed, right?