search

azat-co / expressworks

Learn Express.js from the author of one of the best books on Express.js—Pro Express.js— with this workshop that will teach you basics of Express.js.
MIT License
709 stars 220 forks source link

Hello World task specification unclear #29

Closed DavidHughes closed 9 years ago

DavidHughes commented 9 years ago

problem.txt specifies that the app should be run on 'localhost:3000', but later specifies that the port number will be provided by expressworks.

I have been recently working on the learnyounode & stream-adventure workshops so I assumed that the default of preferring process.argv[2] was still applying to this track.

Either the problem specification should clarify that port 3000 will be used, or the test should be updated to use a random port number which is supplied to the script.

DavidHughes commented 9 years ago

Just compared my solution with this repo's, this issue only really becomes relevant if you manage to get the server listening on port 3000, but with the wrong response message (i.e. I forgot the '!' at end of 'Hello World!').

CamiloMM commented 9 years ago

Indeed, this is kinda silly.

azat-co commented 9 years ago

you can specify 3000 (hard code) or use process.argv[2]