search

azat-co / expressworks

Learn Express.js from the author of one of the best books on Express.js—Pro Express.js— with this workshop that will teach you basics of Express.js.
MIT License
709 stars 220 forks source link

g11n-related infrastructure upgrade #56

Closed tdd closed 9 years ago

tdd commented 9 years ago

Hi there!

First, thanks for ExpressWorks, it's great!

As part of the nodeschool/organizers#64 effort, I went on and localized expressworks to fr. For this to be feasible, it had to be ported to the latest version of workshopper (2.3.1), which required a complete overhaul of the exercise code.

I figured it would be just as good to verify that the workshop still works on the latest versions of Express, Stylus, Jade and body-parser, so I updated these deps too and went again through all exercises, successfully (the dep were not too old, so that was smooth).

I'm also submitting a subsequent PR for the fr L10n specifically, that builds on top of this one. You could merge that second PR alone and be done with the whole thing, but I believe handling this one first, and the l10n-fr one next, makes for better separation of concerns.

We're trying to get this whole translation in npm by Friday night, if that's at all possible wrt your own schedule, as we're hosting the first Paris, FR NodeSchool on Saturday :wink:

I've already translated and merged in learnyounode, and many, many more are on the way.

I am, obviously, available for any questions.

azat-co commented 9 years ago

@tdd thank you! however, can this be auto merge ready?

tdd commented 9 years ago

Hey Azat,

Woah, there had been quite some changes on master in the meantime, sorry I had missed that.

I'm reworking my l10n-fr branch (see #57) so it auto-merges again, based on this new infra-upgrade.