I noticed a bug when writing some code in a project where I have set up this plugin (thank you by the way, it helps out a lot!). When I wrote a named import but didn't specify anything to be imported it was being considered a side-effect import and moved to the bottom of the list of imports. Turns out there is no way to distinguish a side-effect import from an empty named import from looking at the AST, so the only thing I could think of what to look for a } from string in the nodes code to make it not being considered a side-effect import 🙂
azat-io
commented
3 weeks ago
Description
I noticed a bug when writing some code in a project where I have set up this plugin (thank you by the way, it helps out a lot!). When I wrote a named import but didn't specify anything to be imported it was being considered a side-effect import and moved to the bottom of the list of imports. Turns out there is no way to distinguish a side-effect import from an empty named import from looking at the AST, so the only thing I could think of what to look for a
} fromstring in the nodes code to make it not being considered a side-effect import 🙂Additional context
Output from AST explorer
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).