azat / chdig

Dig into ClickHouse with TUI interface.
MIT License
132 stars 13 forks source link

Cannot install on M2 with Sonoma 14.5 #72

Open azat opened 3 months ago

azat commented 3 months ago

This is the error message

==> Installing azat-archive/chdig/chdig
==> make chdig build_completion deploy-binary
Last 15 lines from /Users/daniel/Library/Logs/Homebrew/chdig/01.make:
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling zerocopy v0.7.32
   Compiling utf8parse v0.2.1
   Compiling strsim v0.10.0
   Compiling cc v1.0.83
   Compiling regex-automata v0.4.4
   Compiling darling_core v0.14.4
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
make: *** [chdig] Error 101

Reported-by: @dwinkler1 Original issue: https://github.com/azat-archive/homebrew-chdig/issues/1

azat commented 3 months ago

@dwinkler1 Which version of rust do you have?

azat commented 3 months ago

Updating rust to at least, I would say. 1.74+ should help (not sure about particular version for now, but 1.81 definitely works)

dwinkler1 commented 3 months ago

I was on 1.78. Upgraded to 1.80 now but getting a similar error now. It looks like brew pulled in its own version of rustc also v1.80

==> Fetching azat-archive/chdig/chdig
==> Downloading https://github.com/azat/chdig/archive/refs/tags/v24.1.1.tar.gz
Already downloaded: /Users/daniel/Library/Caches/Homebrew/downloads/44b56dc066f5face6de20504c0f9df649aeb2f8cd22165b6e23c3d46df350ace--chdig-24.1.1.tar.gz
==> Installing chdig from azat-archive/chdig
==> make chdig build_completion deploy-binary
Last 15 lines from /Users/daniel/Library/Logs/Homebrew/chdig/01.make:
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling crossbeam-channel v0.5.11
   Compiling num-complex v0.4.4
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
make: *** [chdig] Error 101
azat commented 3 months ago

OK, I haven't updated the brew formula for a while, can you try modify https://github.com/azat-archive/homebrew-chdig/blob/main/chdig.rb#L4C56-L4C63 to v24.4.1?

And if it will work, please submit an MR!

azat commented 3 months ago

@dwinkler1 I've updated the version in the formula. Can you please try again?