search

azaurus1 / terraform-provider-pinot

A terraform provider for Apache Pinot
https://registry.terraform.io/providers/azaurus1/pinot/latest
Mozilla Public License 2.0
8 stars 1 forks source link

support defining a dimension field as multi-valued #60

Closed guustavov closed 2 months ago

guustavov commented 2 months ago

In order to address #56, https://github.com/azaurus1/go-pinot-api/pull/126 introduced singleValueField schema's property management.

The current PR refers to bumping go-pinot-api version to 0.3.0, allowing terraform provider to manage the property in question. Since this is a configuration for dimension fields only, I'm also suggesting the splitting fieldSpec in dimensionFieldSpec and metricFieldSpec.

Other than that, I also needed to refactor notNull property usage, given json encoder limitation @gbrlcustodio mentioned in https://github.com/azaurus1/go-pinot-api/pull/126 when it comes to omitted falsy values.

Please be thoughtful about this being my first go at Golang 🥁, so probably this one requires a thorough review before moving on. :sweat_smile:

azaurus1 commented 2 months ago

Will merge this and make a new release, thanks @guustavov !