search

azaurus1 / terraform-provider-pinot

A terraform provider for Apache Pinot
https://registry.terraform.io/providers/azaurus1/pinot/latest
Mozilla Public License 2.0
8 stars 1 forks source link

properly append single_value_field to pinot schema #69

Closed guustavov closed 2 months ago

guustavov commented 2 months ago

While bumping pinot provider version to support singleValueField management, I noticed that even though the change showed up correctly in the output of terraform plan, applying the changes to remote resource wasn't working properly.

+ resource "pinot_schema" "schema" {
      + dimension_field_specs             = [
          ...
          + {
              ...
              + single_value_field = false
            },
          ...
}

After taking a deeper look in the former implementation, I realized that singleValueField was added to the structs, but isn't being passed along to schema itself.

The changes in this PR were validated by building the provider locally and performing terraform apply against the remote resource. Changes were applied successfully to it.

azaurus1 commented 2 months ago

Looks good @guustavov, will merge and make new release

azaurus1 commented 2 months ago

new release: v0.5.1