search

azavea / ansible-java

An Ansible role for installing Java.
Apache License 2.0
4 stars 14 forks source link

Add 32bit OS support to OpenJDK #8

Closed hectcastro closed 9 years ago

hectcastro commented 9 years ago

I tested this change with the trusty32 Vagrant box. It correctly resolves facter_architecture to either amd64 or i386 based on host architecture.

Resolves #7

hectcastro commented 9 years ago

Can you please take this branch for a spin to confirm the fix, @eneepo?

eneepo commented 9 years ago

Thanks a lot, it does the job perfectly.

eneepo commented 9 years ago

I found another issue. facter_architecture works ok on boxes which have facter pre installed like vagrant trusty32, vagrant trusty64, ... but the role will fail on servers or boxes which do not have facter.

The first note on ansible setup module describes more about facter dependency.

hectcastro commented 9 years ago

Wow, rookie mistake there. I should have noticed that I was using a Puppet variable. Switched to using the Ansible variable ansible_architecture in https://github.com/azavea/ansible-java/commit/5634741a2749fc569e5410484acb20e0b345003a.

lliss commented 9 years ago

Code looks good. +1 Did not test though.

eneepo commented 9 years ago

I think that's it. It works flawlessly on trusty32 and bare bone ubuntu 14.04 64 bit server.