Hide destination for events with multiple destinations

flibbertigibbet commented 4 years ago

Overview

Hide the destination for events that have multiple destinations.

Instead, show a message indicating that the event has multiple destinations, and link to the website details page.

Demo

Destination not listed on event in list view:

Notes

Since we are not fully implementing the new tours and multiple-destination events features in the Android app, instead we're simply hiding the destination from events that have more than one.

The old destination property is still present on the API response, and corresponds to the first destination when there are multiple.

Testing

Testing this will require using the staging endpoint. Note that the one event currently on staging with multiple destinations is the one pictured above ("We Walk PHL in the Woodlands").

Modify the WEBSERVICE_URL in DestinationWebservice.java here to point to https://staging.gophillygo.org/.
Also modify the website_host string added to strings.xml here to point to staging (used to link out to the event details page).
Install and run app
Go to events list
Destination should not be listed for event with multiple destinations
Tap to go to details for event with multiple destinations
Should see extra section noting multiple destinations, with a link
Link should go to event details page on the site
Other events (with one or no destination) should not display the new section

Closes #173.

lederer commented 4 years ago

One more thing. In the list view, we should render "Multiple destinations" where the single-destination name would be. Same typography as single destination. Not linked.

flibbertigibbet commented 4 years ago

Updated layouts:

List view:

Detail view:

lederer commented 4 years ago

That looks great!

lederer commented 4 years ago

Nice catch @maurizi! I should've seen that 🤦‍♂

@flibbertigibbet Doesn't look like the latest changes you made were pushed, though it looks like they may still contain the regression @maurizi reported.

flibbertigibbet commented 4 years ago

@lederer thanks for pointing it out. I'd pushed to my working branch, but not the upstream copy on this repo (for the tests to run). I've pushed upstream.

flibbertigibbet commented 4 years ago

Fixed the layout for the longer event names that fortunately appeared on staging: Screenshot_1575407064

azavea / cac-tripplanner-android