azavea / cac-tripplanner-android

GoPhillyGo Android app
https://gophillygo.org
Apache License 2.0
3 stars 3 forks source link

Disable notifications toggle #193

Closed ddohler closed 3 years ago

ddohler commented 3 years ago

Overview

Disables the preference toggle for notifications, and changes the help text to an explanation of why the toggle is disabled.

Demo

Screenshot_20210322-134625

Notes

@stephwall I think it might be good to run the copy by CAC before deploying; currently I feel like it reads a bit on the passive-aggressive side. I experimented with more neutral phrasing like "Notifications about nearby places are currently disabled" but I couldn't easily come up with a wording that couldn't be misinterpreted to mean "Notifications about nearby places are currently disabled [because something is wrong with the user's device and maybe they could be re-enabled if the user changes a setting]." I want to find a wording that's clear that the decision to disable the notifications was made by us and that the user can't do anything to re-enable it, but that they're not necessarily gone forever. Also CC @lederer in case you've got any thoughts (though unfortunately our time and budget constraints are pretty tight so I'm not sure how much maneuvering room we have with this).

Testing Instructions

Closes #189

stephwall commented 3 years ago

@ddohler, I don't think it reads as passive aggressive. It's pretty straight forward and accurate. I'll share it with CAC to get their take.

lederer commented 3 years ago

LGTM

Not critical, but any chance you can do an opportunistic tweak to another bit of copy on this page? The two "anonymous reports" toggles use different voices for their descriptions ("how I'm using" vs "events you have marked"). Easily fixed by changing the first one to simply "Send anonymous reports about app usage and crashes."

ddohler commented 3 years ago

@lederer Done! 👍

stephwall commented 3 years ago

@ddohler CAC is good with the copy.