azavea / cac-tripplanner-android

GoPhillyGo Android app
https://gophillygo.org
Apache License 2.0
3 stars 3 forks source link

Upgrade android SDK version to 30 #199

Closed aaronxsu closed 2 years ago

aaronxsu commented 2 years ago

Overview

This PR:

Notes

The update of minSdkVersion to version 21 has two reasons:

  1. Tested the app before upgrading the min version and running on the virtual device with sdk version 19 failed. The reason seemed to be two-folds:
    • Unable to get provider com.google.firebase.provider.FirebaseInitProvider error occurred. Some google search indicated that adding Multidex support would fix the issue, which then opened up a can of warms.
    • okHttp reported an error Expected Android API level 21+ but was 19. The suggestion here was obvious, plus starting from sdk version 21, Multidex support is built-in, which means no code base change needed
  2. This chart (Launch Android Studio -> File -> New -> New project -> Next). It should be fine if we do such an upgrade.

Screen Shot 2022-07-14 at 5 05 53 PM

Testing Instructions

Closes https://github.com/azavea/cac-tripplanner-android/issues/196

aaronxsu commented 2 years ago

Hey @maurizi , I continued from where we left off in the pairing and chased down some more Android linter warnings. They are included in this commit https://github.com/azavea/cac-tripplanner-android/pull/199/commits/a486e2a7a2355fde8fe8ec1495a28a32a5d85a35

Please let me know if it needs changes, and/or if we should create an issue to resolve all remaining warnings too.