azavea / cac-tripplanner

Clean Air Council Circuit Trip Planner and Travelshed
https://gophillygo.org/
Other
15 stars 7 forks source link

Investigate fix to December transit files for deploy #1367

Closed rachelekm closed 10 months ago

rachelekm commented 10 months ago

There were routing issues using the graph object generated from the December transit files which is preventing us from deploying with updated transit data. There are no obvious validation errors in the transit files, or stemming from common issues we already have documented in the deployment instructions, so we need to more thoroughly investigate the transit file validation and include context/a potential fix as part of the deployment instructions.

Below is an example of OTP routing issues with the newly built graph object. The route displayed is completely different than the to/from values and adding transit seems to be off the route entirely:

https://github.com/azavea/cac-tripplanner/assets/36374797/f1a4e61b-4192-4d30-8312-cefffdc90adb

rachelekm commented 10 months ago

SEPTA updated their GTFS files on Dec 5th with bus schedule updates, specifically to Rt 113 due to the opening of the Claymont Transportation Center. There were are no open issues on the gtfs repo following the version update and no obvious changes in the unzipped files that would've caused the routing issues. After re-fetching all transit feeds, validating, and building the new graph object I'm no longer seeing the errors in routing in the issue above. When previously fetching these files in early December, I did have files that were previously invalid with newline characters that had to be cleaned (an existing step documented in the deployment instructions) and there were no erroring files in this round of fetching so maybe there were internal fixes between early December and now. Either way we have a working graph object for this month's deployment and already documented that this is an occasional problem, so I think we can move forward.

Including a screenshot of an otp route using the new SEPTA 113 Claymont Transportation Center (previously, SEPTA 113 Northtowne Plaza) updates:Screenshot 2023-12-18 at 5.46.50 PM.png

As well as now correct routing:

Screenshot 2023-12-18 at 6.46.42 PM.png