Use compact attribution control

azavea / ism-watershed-wellness-snapshot

A tool to collect and display watershed wellness indicators for the International Seaport Museum

1 stars 2 forks source link

Use compact attribution control #54

Closed caseycesari closed 5 years ago

caseycesari commented 5 years ago

Overview

Conserves some screen space, which is especially helpful in the sensor overview view. Previously, the attribution was colliding with the MapBox logo when view on an iPad.

Connects #51

Demo

Before

After

Note

The attribution and Mapbox logo are currently mispositioned when viewing in the browser.

Testing Instructions

Ensure the attribution control is compact by default, and expands when hovered over.

fungjj92 commented 5 years ago

I like the attribution hidden behind the "i" icon. However, it still gets misplaced when a marker is clicked. In Chrome IPad Pro mode:

Kinda hard to see but the "i" is crunched near the "back to map" button

caseycesari commented 5 years ago

Thanks. The attribution and Mapbox logo are displayed inconsistently depending on the device you are using. I see differences between Chrome, iPad simulation in Chrome, and on the actual iPad. I think it's due to the map being different heights and widths depending on the device. I'm going to create an issue to sort this out.

caseycesari commented 5 years ago

Follow-up issue: https://github.com/azavea/ism-watershed-wellness-snapshot/issues/55

fungjj92 commented 5 years ago

Could have expected -- Chrome simulation has proved inconsistent to reality in the past.