search

azavea / ism-watershed-wellness-snapshot

A tool to collect and display watershed wellness indicators for the International Seaport Museum
1 stars 2 forks source link

Create development environment #9

Closed caseycesari closed 5 years ago

caseycesari commented 5 years ago

Overview

Sets up a development environment based on create-react-app, adds support for SASS, and other components of our typical project setup. Also demos that Redux is wired up correctly by implementing the counter demo from the app-template.

Connects #6

Demo

dec-11-2018 15-08-58

Notes

Follow-up issues: #7, #8

Testing Instructions

kellyi commented 5 years ago

Consider adding ./scripts/lint

kellyi commented 5 years ago

I set this up locally, btw, and it worked. Seems like the remaining work here is to place it in a Vagrant VM + Docker.

caseycesari commented 5 years ago

Added a VM and Docker container, and updated the scripts accordingly. Ready for another look.

caseycesari commented 5 years ago

Re: /scripts/lint, I'm going to punt on that until integrating prettier, since that will have to be considered, and it doesn't immediately appear to be that simple to run eslint from the command line with CRA.

kellyi commented 5 years ago

Setting this up now!

kellyi commented 5 years ago

Got this set up and the initial set up is working. However, I do not have hot reloading or anything on file system changes -- I think because the fs changes may not thread through Vagrant and Docker?

caseycesari commented 5 years ago

Good catch. I'll check it out.

caseycesari commented 5 years ago

Ready for another look. Fixed the filesystem by making the changes suggested here: https://github.com/azavea/open-apparel-registry/pull/11#discussion_r240812162.

As we discussed, hot-reloading is not on by default. But I added an issue to figure it out.

caseycesari commented 5 years ago

Thanks for the thorough review!