search

azavea / noaa-hydro-data

NOAA Phase 2 Hydrological Data Processing
11 stars 3 forks source link

Update shape extraction #61

Closed rajadain closed 2 years ago

rajadain commented 2 years ago

Overview

Since PostGIS is now first, before the import, the shapes are no longer stored as bytes in the database, but as hex, needing a different manner of extraction into Shapely.

See https://stackoverflow.com/a/46802086/6995854

Demo

image

Notes

For the original discussion see https://azavea.slack.com/archives/C0167LYVB6D/p1655152367266309

vlulla commented 2 years ago

This looks good to me! Should I just "close with comment"?

rajadain commented 2 years ago

The classic workflow is to "approve" the PR, and then assign it back to the original author, who then merges it.

vlulla commented 2 years ago

OK, good to know! How do I approve? And, sorry for merging your postgis suggested changes (from issue 59?)!

rajadain commented 2 years ago

If you go to the Files Changed tab, there's a Review Changes button to the right, and from there you can Approve or Request Changes or just leave a comment