search

azavea / nyc-trees

NYC Parks Trees Count! 2015 tree census
GNU Affero General Public License v3.0
16 stars 6 forks source link

Crosshairs on Treecorder block selection misaligned #1866

Closed dboyer closed 8 years ago

dboyer commented 8 years ago

On smaller screens, the crosshairs fall behind the help text or are not centered on the map.

dboyer commented 8 years ago

img_0472

jwalgran commented 8 years ago

I think this is the source of the regression

https://github.com/azavea/nyc-trees/commit/e77f3ab23b83c23499f8d2bd8b950d6aeab82c9b#diff-2d673cf24021cc99e1c1a29e34d437deR25

If I revert the media query back to what it was

@media (max-width: $screen-sm) {
    bottom: 20rem;
}

The crosshairs start working again because the map div shrinks properly.

designmatty commented 8 years ago

@jwalgran you're totally right. Adding that 20rem back in will fix this.

maurizi commented 8 years ago

@designmatty I believe adding it back in will break something else on the treecorder screen. I can stop by and show you.

designmatty commented 8 years ago

@maurizi I'll work on it tomorrow so we can chat about it then