azavea / nyc-trees

NYC Parks Trees Count! 2015 tree census
GNU Affero General Public License v3.0
16 stars 6 forks source link

Allow census admins to map any block, regardless of individual mapper or trusted mapper status #199

Closed jwalgran closed 9 years ago

dboyer commented 9 years ago

I thought census admin status meant they had individual mapper status automatically. Is that not true?

If we gave them automatic mapping privileges in any group's territory does that mean they could also map in a group's area when that group has denied individual mappers all together?

I think they should be able to map anywhere automatically and their admin status should trump a group's desire to not allow individual mappers, but I'll ask Parks once I have clarification on the above two questions.

dboyer commented 9 years ago

@jwalgran Parks would like census admins to be able to edit data anywhere. So they automatically get individual mapper status and can map in any group's area without requiring approval from the group first. They can also map in a group's area even if that group has denied individual mappers.

kdeloach commented 9 years ago

I will verify the existing behavior, ensure that census admins can reserve/survey any block regardless of individual/trusted mapper status, and add unit tests.

kdeloach commented 9 years ago

Didn't realize this was not assigned to the current sprint milestone. Will hold off on this until we finish all issues in the current sprint first.

jwalgran commented 9 years ago

Parks has requested, and I think it is a good idea, to use is_superuser = 't' to lift the group_territory restriction in https://github.com/azavea/nyc-trees/blob/develop/src/tiler/sql/user_reservable.sql#L29-L31

jwalgran commented 9 years ago

This doesn't have to happen this sprint, so I am going to put it into the backlog.