search

azavea / osmesa

OSMesa is an OpenStreetMap processing stack based on GeoTrellis and Apache Spark
Apache License 2.0
80 stars 26 forks source link

Fix try-with-resources blocks in replication sources #120

Closed mojodna closed 5 years ago

mojodna commented 5 years ago

Change/changeset replication (ChangeSource, ChangesetSource) include try-with-resources blocks to handle fetching and decompression. They appear to be incorrect; see https://medium.com/@dkomanov/scala-try-with-resources-735baad0fd7d for notes.

Originally posted by @mojodna in https://github.com/azavea/osmesa/pull/106

jpolchlo commented 5 years ago

Does this still apply after killing osmesa.common? Should this issue be transferred over to the geotrellis/vectorpipe repository?

mojodna commented 5 years ago

Possibly? It's also possible that Spark's retry behavior makes this issue moot since it doesn't need to fully clean up after itself.