azavea / osmesa

OSMesa is an OpenStreetMap processing stack based on GeoTrellis and Apache Spark
Apache License 2.0
79 stars 26 forks source link

Split oneoffs to osmesa.apps package #177

Closed CloudNiner closed 4 years ago

CloudNiner commented 4 years ago

These moves were done with IntelliJ "Move Class (F6)" refactor tool. Using this tool does the following:

I had to manually update most package/import refs in docstring comments.

For now I just copy/pasted the analytics/build.sbt to apps/build.sbt. Once everything is moved I'll go through and attempt to clean up the build.sbt's (dependencies, etc). Edit: See comment below, this turned out to be a subpar experience. Taking suggestions for further improvements here if we want to address them now.

Demo

Deployed the changes and observed the checkpoints table increment, and the changes to the class/jar names were applied in the ECS task definition.

Screen Shot 2019-12-11 at 9 36 04 AM Screen Shot 2019-12-11 at 9 47 02 AM
CloudNiner commented 4 years ago

@jpolchlo this is ready for another look, I've completed the originally scoped set of changes and tested them successfully on the staging site (see Demo above). I'm in the process of reverting the staging site changes, as these ones will break a downstream app until I'm able to update the class path refs over there as well.

I'm happy to attempt to address any other changes you had in mind now, as I have about 8 hours left based on the original estimate for this task, so theres some leeway I think to do some additional work.

CloudNiner commented 4 years ago

README needs updating

🤦‍♂ good catch. Will tweak that and the other mentions momentarily.

Also a question about whether the analytics/examples directory should be moved into the new apps package (osmesa.apps.examples).

Yeah, I debated this internally yesterday. I don't have a strong opinion so I decided to leave them where they are because they're examples of how one might use the constructs defined in the analytics project. They're good templates for writing your own command apps and I figured it would be good to have them closer to the source that people will be looking at. I'm happy to move them though given a constructive argument for putting them in apps. Thoughts from your end?

jpolchlo commented 4 years ago

Ah, right. Somehow it slipped my mind that we discussed moving these examples to Vectorpipe, since they don't stretch the OSMesa-provided features at all. Let me suggest that they move there instead. I think the other apps are demonstration enough of the feature set of OSMesa.

CloudNiner commented 4 years ago

moving these examples to Vectorpipe

👍 right. Going to address now since I have some time and this shouldn't take long.