azavea / osmesa

OSMesa is an OpenStreetMap processing stack based on GeoTrellis and Apache Spark
Apache License 2.0
79 stars 26 forks source link

Do not count point stats differently during batch ingest #204

Closed jpolchlo closed 3 years ago

jpolchlo commented 3 years ago

A bug was discovered where users had committed changes that were picked up by the streaming update, but lost after a bulk ingest. These edits were valid, so there was understandable consternation.

The problem is that we had a special pointCounts column function used only during bulk ingest that omitted a number of categories of edits from consideration if the underlying geometry was a point, including nodes tagged as buildings (which is permissible).

This is a quick fix PR that seems to address the problem. We ought to revisit this code, in case further streamlining is possible now that points/ways/relations are all being counted similarly.