azavea / pfb-network-connectivity

PFB Bicycle Network Connectivity
Other
40 stars 10 forks source link

Remove filters for created_by, modified_by and fips_code for Analysis Batch #814

Closed kevinearldenny closed 3 years ago

kevinearldenny commented 3 years ago

Overview

Ensure that neighborhoods created as part of an AnalysisBatch job are matched with existing neighborhoods, even if they were created by a different user within the organization or if they don't have a fips_code that matches with the existing neighborhood's fips_code. Neighborhoods are now only matched on the fields defined in unique_together. Test cases added to validate AnalysisBatch neighborhood matching logic.

Demo

N/A

Notes

I'm running into some issues running ./scripts/test locally, but I am hopeful that the test cases will work as written. I'm continuing to troubleshoot this on my end - I have attached the output logs of this command here for review in case someone is able to assist in rectifying the issue here.

Testing Instructions

Path 1 (admin frontend)

Path 2 (Django test suite)

Checklist

Resolves #795

django_test.log