azavea / pfb-network-connectivity

PFB Bicycle Network Connectivity
Other
40 stars 10 forks source link

Sub-PR to #807: alternate approach to the analysis part of showing default speed limits #817

Closed KlaasH closed 3 years ago

KlaasH commented 3 years ago

Overview

This is a sub-PR for #807, replacing the analysis-side parts with a different approach.

My concerns with the upstream approach are:

I wasn't sure how to do a good job of describing what I was picturing instead, nor was I sure it was actually coherent and complete, so I did it in code.

This version of things:

Notes

Testing Instructions

There are a few different permutations of this thing:

Connects to #804

kevinearldenny commented 3 years ago

Okay, so after testing the 3 paths, all are working as expected.

  1. New analysis for Boulder, CO - Speed limit is propagated and displayed on Neighborhood Detail map
  2. Imported analysis for Appleton, WI - Speed limit is included and displayed on Neighborhood Detail map as expected
  3. Imported analysis for Green Bay, WI - Speed limit is not included, so it is not displayed on Neighborhood Detail map

Looks like this is good to go 👍