search

azavea / pfb-network-connectivity

PFB Bicycle Network Connectivity
Other
40 stars 10 forks source link

Port from Jenkins to Github Actions #903

Closed BryanQuigley closed 1 year ago

BryanQuigley commented 1 year ago

Most items copied over with only minor changes, except:

Commenting out update_batch_definitions as that would need a good number of changes to support not using an AWS profile in Github and we are looking into improving that as my potential next task anyway.

Slack notifications for build success or failure are covered when pushing a PR by the Github integration.

REMINDER: Add infra apply when PR approved

Resolves: #882

Demo

On PR, Terraform is not run: https://github.com/azavea/pfb-network-connectivity/runs/7904131095?check_suite_focus=true On Push to to test (and others) it is run; https://github.com/azavea/pfb-network-connectivity/runs/7888427429?check_suite_focus=true

Testing Instructions

Checklist

BryanQuigley commented 1 year ago

I left infra apply off until review is complete - plan to add it when it's done.

BryanQuigley commented 1 year ago

The failure was due to GH Actions being down.

lydiascarf commented 1 year ago

where in the push to test action run from the test instructions does terraform run? I was looking for that infra script call that gets skipped in the PR run

BryanQuigley commented 1 year ago

Look at this one: https://github.com/azavea/pfb-network-connectivity/actions/runs/3003482711/jobs/4821824010

The ones that are made from the PR will not run it.

BryanQuigley commented 1 year ago

We do get build notifications when the build is from a PR. but not automagically when pushing manually, etc. That should be just 1 point to add in the future if we find ourselves really needing it.