Update Docker provisioning and docker compose command

KlaasH commented 4 months ago

Overview

Updates the Docker installation to:

Not use the azavea.docker role (which is no longer maintained), inlining the relevant steps instead.
Use a newer version
Invoke Docker Compose with 'docker compose' (rather than 'docker-compose') since that's how it works in newer Docker versions.

I also updated the Vagrant base box, mainly because we might as well not be out of date if we don't have to be, and renamed the shared 'django' docker-compose config to 'django-common', since apparently docker compose now treats it as a name collision to have services in different files with the same name.

Resolves #952

Notes

I'm not sure where things stand these days with Vagrant/Virtualbox on Mac machines. Possibly most of these changes won't be relevant. Though the docker-compose->docker compose change will likely help if the alternate strategy is to run Docker-on-host.

Testing Instructions

Destroy your virtual machine, if you had one (vagrant destroy)
Spin up a new one with ./scripts/setup (unless you're doing docker-only, in which case just run ./scripts/update)
Start the server (./scripts/server, whether in or out of the VM)
Confirm that the local server works (http://localhost:9301/)
Optional: import some boundaries (here's a small sample batch file) and run an analysis for one of them.

Checklist

[x] Add entry to CHANGELOG.md

KlaasH commented 4 months ago

Ok, the "TASK [pfb.docker : Configure the Docker APT repository]" error was because I forgot to add a new file to git. I meant to do a clean run on a separate checkout to make sure everything was in place, but I guess I forgot to go back and do that after all the changes were in. I pushed a fixup for that error.

The Ansible version error is a little confusing because I did just do scripts/setup on a clean repo and it got past that step just fine. Can you take a look at what version of the base box you have? The third line of my output was:

Checking if box 'bento/ubuntu-22.04' version '202401.31.0' is up to date...

and I believe the answer was yes, since it didn't print a message about a newer version being available. I wonder if you might have an older version of the base box on your machine and it has an older version of Ansible. Possibly 'latest' would make sense as a plan, but I kind of prefer the idea of keeping it specified if we can.

KlaasH commented 4 months ago

Ok, my VM build with the fixup for the missed file worked. Could you try it again? Given that your first attempt worked partly and exposed a real bug, I think we should be able to get to the point of confirming that it works for more than just me, which would be nice.

KlaasH commented 4 months ago

Ok, I'm going to say that's close enough. It's weird that it says the requested version isn't available then includes it in the list, but if we tried to solve every Vagrant/Virtualbox mystery, we'd never have time for anything else...

azavea / pfb-network-connectivity