Restore jsx-a11y linting rules

kellyi commented 5 years ago

Overview

replace interactive a elements with buttons
re-enable jsx-a11y linting rules
update styles for buttons

Connects #63

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

check out the netlify build to verify that the map, help, and authenticated menu actions are styled appropriately
run ./scripts/lint and verify that it passes
grep for eslint-disable and verify that it doesn't appear in the codebase

rajadain commented 5 years ago

I'm seeing these errors in the console, but they look unrelated to the work here:

rajadain commented 5 years ago

Also discovered #70, but that's also present on develop.

kellyi commented 5 years ago

Thanks! I guess we may not have ever used this with both the search bar and the authentication menu both configured simultaneously, so we should fix that. We can wait a little bit on that since neither the Parcel Viewer nor Credits Explorer have an authentication menu.

azavea / pwd-unitybar