Add Google geocoder - Githubissues

KlaasH commented 8 years ago

Adds a Google geocoder.

Also:

Breaks the geocoders out into separate files rather than defining them all in services/__init__.py
Fixes a variety of little linting errors
Gets the tests working by hiding the Nominatim tests behind a MapQuest key check and the tests for all ESRI endpoints except WGS behind an ESRI key check. It's possible that both of those are actually defunct, but figuring out and fixing that was beyond the scope of what I'm here for.
- Note that the Census tests are currently failing because http://geocoding.geo.census.gov/geocoder/ is down, but I think they were working on Thursday and I see no other indication that the service is going away (https://www.census.gov/geo/maps-data/data/geocoder.html) so I'm interpreting that as a transient error.

sharph commented 8 years ago

LGTM! I'd still ask for someone on another team who has worked on this library to take a look, especially in regards to the restructuring.

KlaasH commented 8 years ago

The vast majority of the work on this project was by @joetric, who has moved on. Other contributors include @ddohler, @jwalgran, and @flibbertigibbet, who all seem to have made small visits to the code for specific purposes. Any of you have thoughts on this?

ddohler commented 8 years ago

:+1: The everything-in-one-file approach was unwieldy and this library definitely needed some love.

azavea / python-omgeo

Add Google geocoder #23