azavea / python-omgeo

OMGeocoder - A python geocoding abstraction layer
http://python-omgeo.readthedocs.io/en/latest/
MIT License
36 stars 14 forks source link

Remove usage of the ESRI WGS geocoder `find` endpoint #30

Closed jwalgran closed 7 years ago

jwalgran commented 7 years ago

ESRI deprecated the find endpoint. On or around June 28th 2017 several WGS related unit test started failing. This commit removes the usage of find and passes all ESRI WGS geocoder requests to the findAddressCandidates endpoint. The capitalization of a few attributes returned from the findAddressCandidates endpoint differed from what the code expected and required changes.


Testing

Before the ESRI WGS test began failing, these three tests were already failling:

Only these three tests should fail when running the unit tests.


Connects to https://github.com/OpenTreeMap/otm-cloud/issues/384

hectcastro commented 7 years ago

You ran these tests with all of the API keys present or just the Esri ones?

maurizi commented 7 years ago

@hectcastro I believe the ESRI geocoding services do not require an API key.

jwalgran commented 7 years ago

When running the tests I exported the same API keys that the CI job on jenkins01 does.